Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update googleAnalytics.tsx to properly track goals #110

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Update googleAnalytics.tsx to properly track goals #110

merged 1 commit into from
Sep 1, 2023

Conversation

rihp
Copy link
Contributor

@rihp rihp commented Sep 1, 2023

I think the messages are not being logged because they had to be set as the label, instead of the value which should be a float.

@rihp
Copy link
Contributor Author

rihp commented Sep 1, 2023

image As per https://developers.google.com/tag-platform/devguides/events

@dOrgJelli dOrgJelli merged commit dde6a5f into dev Sep 1, 2023
1 check passed
@cbrzn cbrzn deleted the rihp-patch-2 branch December 5, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@nerfZael nerfZael Awaiting requested review from nerfZael nerfZael is a code owner

@pileks pileks Awaiting requested review from pileks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rihp @dOrgJelli